Looks great to me, quick eyeball on mobile. Will come back and merge probably on Sunday

I almost made this exact same PR earlier this afternoon... The irony is this is fixed in symfony/process:^4.1.

Bump, ran into this recently. I'd rather not pin on an older version.

Upstream fix in https://github.com/symfony/symfony/blob/5.0/src/Symfony/Component/Process/Process.php#L1214

Alternatively, as the prefered install seems to be via phar, just change the composer dependencies to:

"symfony/process": "^4.1"

@heddn I don't think that works with Drupal projects though since drupal/core requires symfony/process as ~3.4.0.

EDIT: Right, you said phar, nevermind about the above then if you're using a phar :) For those who aren't using a phar though... it's tough luck until this is merged.

Could we tag a new release so this gets picked up by my CI?

Yes please for a release!

We'd like to use https://www.drupal.org/project/upgrade_status, but it needs 0.12 of phpstan/phpstan-deprecation-rules, but we use BLT which pins drupal-check <1.1.0 (acquia/blt#4001) and 0.11 of phpstan/phpstan-deprecation-rules, due to #131.

By the way, can #131 be closed now this is merged?

Thank you!

I kept the issue open to remind me to tag the release 😬

1.1.1 is out :) thanks for all of the patience